[flashrom-gerrit] Change in flashrom[master]: it85spi.c: Refactor singleton states into reentrant pattern

[Anastasia Klimchuk (Code Review)]

Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47655 )

Change subject: it85spi.c: Refactor singleton states into reentrant pattern
......................................................................

Patch Set 8:

(2 comments)

addressing some comments

https://review.coreboot.org/c/flashrom/+/47655/6/it85spi.c 
File it85spi.c:

https://review.coreboot.org/c/flashrom/+/47655/6/it85spi.c@242 
PS6, Line 242: 	if (!flash || !flash->mst || !flash->mst->spi.data) {
             : 		msg_perr("Unable to extract data from flash context.\n");
             : 		return SPI_GENERIC_ERROR;
             : 	}
> I don't know why gerrit lost this comment twice in a row.. […]

Done

https://review.coreboot.org/c/flashrom/+/47655/6/it85spi.c@308 
PS6, Line 308: 	data->shm_io_base = 0;
             : 	data->ce_high = NULL;
             : 	data->ce_low = NULL;
             : 	data->it85xx_scratch_rom_reenter = 0;
             :
> agree, option (a) is ideal imho.

I removed explicit initialisation of struct members, hope that my understanding of the comment is correct.