addressing some comments

View Change

2 comments:

• File it85spi.c:

  • Patch Set #6, Line 242:

    	if (!flash || !flash->mst || !flash->mst->spi.data) {
    		msg_perr("Unable to extract data from flash context.\n");
    		return SPI_GENERIC_ERROR;
    	}
    

    I don't know why gerrit lost this comment twice in a row.. […]

    Done

  • Patch Set #6, Line 308:

    	data->shm_io_base = 0;
    	data->ce_high = NULL;
    	data->ce_low = NULL;
    	data->it85xx_scratch_rom_reenter = 0;
    
    

    agree, option (a) is ideal imho.

    I removed explicit initialisation of struct members, hope that my understanding of the comment is correct.

To view, visit change 47655. To unsubscribe, or for help writing mail filters, visit settings.