Attention is currently required from: Edward O'Callaghan, Sergii Dmytruk.
Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69846 )
Change subject: writeprotect.c: Split register value/mask calculation into pure func ......................................................................
Patch Set 3:
(4 comments)
This change is ready for review.
Commit Message:
https://review.coreboot.org/c/flashrom/+/69846/comment/4187c6ac_a15a8765 PS1, Line 7: move wp_bits -> register values/masks conversion into func
"Split out reg mask/val calculations into pure func"
Done
https://review.coreboot.org/c/flashrom/+/69846/comment/86a30c50_8428abb1 PS1, Line 11: .
"This avoids monadic transformer stacks where unit-testing cannot penetrate well to give suitable co […]
Done
https://review.coreboot.org/c/flashrom/+/69846/comment/18dd03f2_626ffc93 PS1, Line 13: TEST=ninja test
`BUG=b:259013033`
Done
File writeprotect.c:
https://review.coreboot.org/c/flashrom/+/69846/comment/ed022bd1_03fd3bb5 PS1, Line 170: bit_masks, write_masks
Swapped arguments. […]
Done