Attention is currently required from: Edward O'Callaghan, Sergii Dmytruk.
View Change
4 comments:
Commit Message:
Patch Set #1, Line 7: move wp_bits -> register values/masks conversion into func
"Split out reg mask/val calculations into pure func"
Done
Patch Set #1, Line 11: .
"This avoids monadic transformer stacks where unit-testing cannot penetrate well to give suitable co […]
Done
Patch Set #1, Line 13: TEST=ninja test
`BUG=b:259013033`
Done
File writeprotect.c:
To view, visit change 69846. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I604478ecbb70392c5584bf5d87c76b6f20f882b1
Gerrit-Change-Number: 69846
Gerrit-PatchSet: 3
Gerrit-Owner: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Comment-Date: Tue, 22 Nov 2022 02:44:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-MessageType: comment