Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62891 )
Change subject: ichspi: Introduce FCYCLE_MASK(n) macro ......................................................................
Patch Set 4:
(5 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62891/comment/9b6d37cd_6ed6882d PS3, Line 12: Also, drops unused macros (PCH100_HSFC_FCYCLE_OFF and : PCH100_HSFC_FCYCLE).
Can you extract this into a separate patch? Seems like these are two different things (corresponding […]
Ack
https://review.coreboot.org/c/flashrom/+/62891/comment/69468919_764fb495 PS3, Line 16: brya
I see you are using brya to test this chain, if you could add info what chipset brya has, it would b […]
Ack
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/62891/comment/94907b06_88d917d6 PS3, Line 80: /* Changed HSFC Control bits */
Should the comment be removed as well?
Ack
https://review.coreboot.org/c/flashrom/+/62891/comment/1b683917_abed301f PS3, Line 500: reg_val, ", ");
No new line needed, this print statement can be on one line […]
Ack
https://review.coreboot.org/c/flashrom/+/62891/comment/6934af8a_96094e6a PS3, Line 505: reg_val, ", ");
Same as previous
Ack