Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

View Change

5 comments:

• Commit Message:

  • Patch Set #3, Line 12:

    Also, drops unused macros (PCH100_HSFC_FCYCLE_OFF and
    PCH100_HSFC_FCYCLE).
    

    Can you extract this into a separate patch? Seems like these are two different things (corresponding […]

    Ack

  • Patch Set #3, Line 16: brya

    I see you are using brya to test this chain, if you could add info what chipset brya has, it would b […]

    Ack

• File ichspi.c:

  • Patch Set #3, Line 80: /* Changed HSFC Control bits */

    Should the comment be removed as well?

    Ack

  • Patch Set #3, Line 500: reg_val, ", ");

    No new line needed, this print statement can be on one line […]

    Ack

  • Patch Set #3, Line 505: reg_val, ", ");

    Same as previous

    Ack

To view, visit change 62891. To unsubscribe, or for help writing mail filters, visit settings.