Attention is currently required from: Nico Huber, Anastasia Klimchuk.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54044 )
Change subject: usbblaster_spi.c: Refactor singleton states into reentrant pattern
......................................................................
Patch Set 1:
(2 comments)
File usbblaster_spi.c:
https://review.coreboot.org/c/flashrom/+/54044/comment/23e52223_42e21f59
PS1, Line 55: struct ftdi_context ftdic;
Oh I had the same question in CB:52774 and I explained why I am doing this (in short, mostly so that […]
Ack
https://review.coreboot.org/c/flashrom/+/54044/comment/87f21f2b_1d35b965
PS1, Line 185: struct ftdi_context ftdic;
I usually try to allocate data as late as possible to simplify error paths (as soon as you allocate […]
I believe this patch is fine, hence the +2. I don't have a strong opinion on this.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/54044
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia81f9f40c7eab430a8b304d0b197ce7c75bf5ace
Gerrit-Change-Number: 54044
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Wed, 12 May 2021 09:07:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment