Attention is currently required from: Nico Huber, Anastasia Klimchuk.

View Change

2 comments:

• File usbblaster_spi.c:

  • Patch Set #1, Line 55: struct ftdi_context ftdic;

    Oh I had the same question in CB:52774 and I explained why I am doing this (in short, mostly so that […]

    Ack

  • Patch Set #1, Line 185: struct ftdi_context ftdic;

    I usually try to allocate data as late as possible to simplify error paths (as soon as you allocate […]

    I believe this patch is fine, hence the +2. I don't have a strong opinion on this.

To view, visit change 54044. To unsubscribe, or for help writing mail filters, visit settings.