Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Sergii Dmytruk. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58475 )
Change subject: spi25_statusreg: make register read/write functions generic ......................................................................
Patch Set 10:
(4 comments)
File spi25_statusreg.c:
https://review.coreboot.org/c/flashrom/+/58475/comment/ff650868_863f2a48 PS9, Line 31:
If you add new line it looks nicer, and easier to read (and I think consistent with most of long com […]
Done
https://review.coreboot.org/c/flashrom/+/58475/comment/050c051c_086d620a PS9, Line 32:
Is this one extra space? probably not needed?
Done
https://review.coreboot.org/c/flashrom/+/58475/comment/2aa4a2d0_0ed8431e PS9, Line 120: msg_cerr("Cannot read register: not supported by chip\n");
Just to clarify: here the error comes in else clause, which I understand. […]
The `if (write_cmd_len == 0)` is used to check this. The next CL adds some nested if statements that prevent using an `else` statement.
https://review.coreboot.org/c/flashrom/+/58475/comment/b51b7af4_c192904f PS9, Line 143: uint8_t status;
Is it 0 initialised?
Done