Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Sergii Dmytruk.

View Change

4 comments:

• File spi25_statusreg.c:

  • Patch Set #9, Line 31:

    If you add new line it looks nicer, and easier to read (and I think consistent with most of long com […]

    Done

  • Patch Set #9, Line 32:

    Is this one extra space? probably not needed?

    Done

  • Patch Set #9, Line 120: msg_cerr("Cannot read register: not supported by chip\n");

    Just to clarify: here the error comes in else clause, which I understand. […]

    The `if (write_cmd_len == 0)` is used to check this. The next CL adds some nested if statements that prevent using an `else` statement.

  • Patch Set #9, Line 143: uint8_t status;

    Is it 0 initialised?

    Done

To view, visit change 58475. To unsubscribe, or for help writing mail filters, visit settings.