Joshua Wise has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44420 )
Change subject: Add support for Comet Lake-U/400-series PCH ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/flashrom/+/44420/2/chipset_enable.c File chipset_enable.c:
https://review.coreboot.org/c/flashrom/+/44420/2/chipset_enable.c@2016 PS2, Line 2016: {0x8086, 0x02a4, B_S, DEP, "Intel", "Comet Lake", enable_flash_pch400},
you're right, so why was it being added in 44921 ?
It's very possible that I didn't know what I was doing :) I added a PCI ID for something that reported in `lspci` as a SPI controller: "00:1f.5 Serial bus controller [0c80]: Intel Corporation Comet Lake SPI (flash) Controller".
Oddly, 44921 *did* work for me, even if it shouldn't have! I wonder why.