View Change
1 comment:
File chipset_enable.c:
Patch Set #2, Line 2016: {0x8086, 0x02a4, B_S, DEP, "Intel", "Comet Lake", enable_flash_pch400},
you're right, so why was it being added in 44921 ?
It's very possible that I didn't know what I was doing :) I added a PCI ID for something that reported in `lspci` as a SPI controller: "00:1f.5 Serial bus controller [0c80]: Intel Corporation Comet Lake SPI (flash) Controller".
Oddly, 44921 *did* work for me, even if it shouldn't have! I wonder why.
To view, visit change 44420. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I43b4ad1eecfed16fec59863e46d4e997fbe45f1b
Gerrit-Change-Number: 44420
Gerrit-PatchSet: 3
Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Joshua Wise <joshua@joshuawise.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Sat, 29 Aug 2020 23:17:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier <matt.devillier@gmail.com>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment