Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47276 ) Change subject: flashrom: import chip restore handler from cros flashrom ...................................................................... Patch Set 6: (2 comments) https://review.coreboot.org/c/flashrom/+/47276/6//COMMIT_MSG Commit Message: https://review.coreboot.org/c/flashrom/+/47276/6//COMMIT_MSG@7 PS6, Line 7: import this isn't true because you re-implemented this for upstream. `flashrom.c: Implement chip state restore callback hooking` https://review.coreboot.org/c/flashrom/+/47276/6//COMMIT_MSG@12 PS6, Line 12: This is used by the s25f driver added in a subsequent patch, : which changes chips with a hybrid (non-uniformly sized) sector : layout to a uniform layout, and registers a restore function : to change the chip back to the hybrid layout at exit. This is very hard to parse. ``` This is used by Spansion chip support added in a subsequent patch as to allows switching between hybrid non-uniformly sized and uniform sector layouts pre-post flashing. The framework allows for a restore function to be registered to change the chip back to the hybrid layout upon tear-down. ``` -- To view, visit https://review.coreboot.org/c/flashrom/+/47276 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2a522dc1fd3952793fbcad70afc6dd43850fbbc5 Gerrit-Change-Number: 47276 Gerrit-PatchSet: 6 Gerrit-Owner: Nikolai Artemiev <nartemiev@google.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Andrew McRae <amcrae@chromium.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-CC: Sam McNally <sammc@google.com> Gerrit-Comment-Date: Mon, 23 Nov 2020 04:18:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment