Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47276 )
Change subject: flashrom: import chip restore handler from cros flashrom ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/flashrom/+/47276/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/47276/6//COMMIT_MSG@7 PS6, Line 7: import this isn't true because you re-implemented this for upstream.
`flashrom.c: Implement chip state restore callback hooking`
https://review.coreboot.org/c/flashrom/+/47276/6//COMMIT_MSG@12 PS6, Line 12: This is used by the s25f driver added in a subsequent patch, : which changes chips with a hybrid (non-uniformly sized) sector : layout to a uniform layout, and registers a restore function : to change the chip back to the hybrid layout at exit. This is very hard to parse.
``` This is used by Spansion chip support added in a subsequent patch as to allows switching between hybrid non-uniformly sized and uniform sector layouts pre-post flashing. The framework allows for a restore function to be registered to change the chip back to the hybrid layout upon tear-down.
```