Attention is currently required from: Thomas Heijligen. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55123 )
Change subject: CONFIG_DEFAULT_PROGRAMMER_NAME: Use programmer name instead of enum ......................................................................
Patch Set 10: Code-Review+2
(2 comments)
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/55123/comment/1d17f939_01949db0 PS5, Line 554: #ifndef CONFIG_DEFAULT_PROGRAMMER_ARGS : #define CONFIG_DEFAULT_PROGRAMMER_ARGS "" : #endif
This too should be covered outside C. […]
Done
File meson.build:
https://review.coreboot.org/c/flashrom/+/55123/comment/62ea62cc_f1707352 PS10, Line 448: cargs += '-DCONFIG_DEFAULT_PROGRAMMER_ARGS="' + config_default_programmer_args + '"' Doesn't this work for an empty string as well?