Attention is currently required from: Thomas Heijligen.
Patch set 10:Code-Review +2
View Change
2 comments:
File cli_classic.c:
Patch Set #5, Line 554:
#ifndef CONFIG_DEFAULT_PROGRAMMER_ARGS
#define CONFIG_DEFAULT_PROGRAMMER_ARGS ""
#endif
This too should be covered outside C. […]
Done
File meson.build:
Patch Set #10, Line 448: cargs += '-DCONFIG_DEFAULT_PROGRAMMER_ARGS="' + config_default_programmer_args + '"'
Doesn't this work for an empty string as well?
To view, visit change 55123. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I976447787c6f6bfbdc0145d80d61e1ddcf97ac33
Gerrit-Change-Number: 55123
Gerrit-PatchSet: 10
Gerrit-Owner: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-CC: Xiang W <wxjstz@126.com>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Comment-Date: Tue, 08 Jun 2021 14:41:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment