Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk.
Namyoon Woo has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54748 )
Change subject: dummyflasher.c: Extract params processing into a separate function
......................................................................
Patch Set 4:
(1 comment)
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/54748/comment/0f1ceeb0_dc88e528
PS4, Line 834: return 0;
nit: I understand that it will eventually go to dummy_init_out because data->emu_chip == EMULATE_NONE. But it is returning 0 implying 'ok' case. TBH, it confuses me at the first look.
Can it handle as same as line 925~929 for consistency? (though it would change the original code flow.)
--
To view, visit
https://review.coreboot.org/c/flashrom/+/54748
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I04f55f77bb4703f1d88b2191c45a22be3c97bf87
Gerrit-Change-Number: 54748
Gerrit-PatchSet: 4
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Namyoon Woo
namyoon@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Wed, 02 Jun 2021 02:07:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment