Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk.

View Change

1 comment:

• File dummyflasher.c:

  • Patch Set #4, Line 834: return 0;

    nit: I understand that it will eventually go to dummy_init_out because data->emu_chip == EMULATE_NONE. But it is returning 0 implying 'ok' case. TBH, it confuses me at the first look.
    Can it handle as same as line 925~929 for consistency? (though it would change the original code flow.)

To view, visit change 54748. To unsubscribe, or for help writing mail filters, visit settings.