Attention is currently required from: Paul Menzel, Edward O'Callaghan, Daniel Campello. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62862 )
Change subject: helpers.c: use unsigned int for bit shifts (ASAN) ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62862/comment/467687af_d294a6b0 PS2, Line 11: error detected Lets say "error detected in chromium tree", that would explain where flashrom-9999 is coming from.
https://review.coreboot.org/c/flashrom/+/62862/comment/0653997f_05258a15 PS2, Line 18: TEST=FEATURES=test emerge-amd64-generic flashrom You probably ran tests in upstream tree too (before sending the patch)? (meson tests). I would add this as first line in TEST tag, commit needs to have some info how the patch was tested on upstream tree. And then emerge with tests can come as second line.