Attention is currently required from: Paul Menzel, Edward O'Callaghan, Daniel Campello.
Patch set 2:Code-Review +1
View Change
2 comments:
Commit Message:
Patch Set #2, Line 11: error detected
Lets say "error detected in chromium tree", that would explain where flashrom-9999 is coming from.
Patch Set #2, Line 18: TEST=FEATURES=test emerge-amd64-generic flashrom
You probably ran tests in upstream tree too (before sending the patch)? (meson tests). I would add this as first line in TEST tag, commit needs to have some info how the patch was tested on upstream tree.
And then emerge with tests can come as second line.
To view, visit change 62862. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib595f13c29dd5c0775e074801756e4f920b4daaf
Gerrit-Change-Number: 62862
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Campello <campello@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Daniel Campello <campello@chromium.org>
Gerrit-Comment-Date: Thu, 17 Mar 2022 23:06:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment