Attention is currently required from: Stefan Reinauer, Edward O'Callaghan, Angel Pons.
Xiang Wang has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49256 )
Change subject: programmer.h: remove unused interfaces of bitbang_spi_master
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS3:
The meaning of the set_sck_set_mosi/set_sck_get_miso interface is ambiguous
set_sck_set_mosi should be set_mosi befor set_sck
set_sck_get_miso should be get_miso after set_sck
The replacement function in the absence of the set_sck_set_mosi interface is also wrong
static void bitbang_spi_set_sck_set_mosi(const struct bitbang_spi_master * const master, int sck, int mosi)
{
if (master->set_sck_set_mosi) {
master->set_sck_set_mosi(sck, mosi);
return;
}
master->set_sck(sck);
master->set_mosi(mosi);
}
--
To view, visit
https://review.coreboot.org/c/flashrom/+/49256
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I68e5fc39cf831e3b7d98a6e4797b36584c6082e8
Gerrit-Change-Number: 49256
Gerrit-PatchSet: 6
Gerrit-Owner: Xiang Wang
merle@hardenedlinux.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Shawn C
citypw@hardenedlinux.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sat, 09 Jan 2021 16:54:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment