Attention is currently required from: Stefan Reinauer, Edward O'Callaghan, Angel Pons.

View Change

1 comment:

• Patchset:

  • Patch Set #3:

    The meaning of the set_sck_set_mosi/set_sck_get_miso interface is ambiguous

    set_sck_set_mosi should be set_mosi befor set_sck
    set_sck_get_miso should be get_miso after set_sck

    The replacement function in the absence of the set_sck_set_mosi interface is also wrong

    static void bitbang_spi_set_sck_set_mosi(const struct bitbang_spi_master * const master, int sck, int mosi)
    {
    	if (master->set_sck_set_mosi) {
    		master->set_sck_set_mosi(sck, mosi);
    		return;
    	}
    > 	master->set_sck(sck);
    	master->set_mosi(mosi);
    }

To view, visit change 49256. To unsubscribe, or for help writing mail filters, visit settings.