Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41533 )
Change subject: raiden_debug_spi.c: Add support for USB SPI protocol V2 ......................................................................
Patch Set 12:
(9 comments)
https://review.coreboot.org/c/flashrom/+/41533/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/41533/2//COMMIT_MSG@7 PS2, Line 7: Adds
Add
Done
https://review.coreboot.org/c/flashrom/+/41533/2//COMMIT_MSG@9 PS2, Line 9: Adds
Add
Done
https://review.coreboot.org/c/flashrom/+/41533/2/raiden_debug_spi.c File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/41533/2/raiden_debug_spi.c@726 PS2, Line 726:
I'm using spaces to align these multi-line function calls, especially the ones with mutli-line strin […]
Ack.
https://review.coreboot.org/c/flashrom/+/41533/2/raiden_debug_spi.c@854 PS2, Line 854: } if
Yup, that vanished somewhere.
Done
https://review.coreboot.org/c/flashrom/+/41533/2/raiden_debug_spi.c@864 PS2, Line 864: msg_perr("Raiden: Unexpected packet id = %d",
The indentation levels here correspond to a function, a loop, and a single level of conditions, I do […]
Ah, since the `else` was indeed missing, swapping the branches isn't really doable.
https://review.coreboot.org/c/flashrom/+/41533/2/raiden_debug_spi.c@913 PS2, Line 913: } else {
That applies to the ctx_data->write_command but not supporting a 'restart_response_v2' response isn' […]
Ack
https://review.coreboot.org/c/flashrom/+/41533/3/raiden_debug_spi.c File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/41533/3/raiden_debug_spi.c@1108 PS3, Line 1108: NULL,
Yes, it was tested on the version of flashrom in chromeos. […]
Ack (I don't like null pointers, but we can handle it in a separate patch)
https://review.coreboot.org/c/flashrom/+/41533/5/raiden_debug_spi.c File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/41533/5/raiden_debug_spi.c@1024 PS5, Line 1024: transmit
no need for the status intermediate, just return transmit_packet() directly.
Done
https://review.coreboot.org/c/flashrom/+/41533/5/raiden_debug_spi.c@1139 PS5, Line 1139: ;
\n
Done