View Change

9 comments:

• Commit Message:

  • Patch Set #2, Line 7: Adds

    Add

    Done

  • Patch Set #2, Line 9: Adds

    Add

    Done

• File raiden_debug_spi.c:

  • Patch Set #2, Line 726:

    I'm using spaces to align these multi-line function calls, especially the ones with mutli-line strin […]

    Ack.

  • Patch Set #2, Line 854: } if

    Yup, that vanished somewhere.

    Done

  • Patch Set #2, Line 864: msg_perr("Raiden: Unexpected packet id = %d",

    The indentation levels here correspond to a function, a loop, and a single level of conditions, I do […]

    Ah, since the `else` was indeed missing, swapping the branches isn't really doable.

  • Patch Set #2, Line 913: } else {

    That applies to the ctx_data->write_command but not supporting a 'restart_response_v2' response isn' […]

    Ack

• File raiden_debug_spi.c:

  • Patch Set #3, Line 1108: NULL,

    Yes, it was tested on the version of flashrom in chromeos. […]

    Ack (I don't like null pointers, but we can handle it in a separate patch)

• File raiden_debug_spi.c:

  • Patch Set #5, Line 1024: transmit

    no need for the status intermediate, just return transmit_packet() directly.

    Done

  • Patch Set #5, Line 1139: ;

    \n

    Done

To view, visit change 41533. To unsubscribe, or for help writing mail filters, visit settings.