Attention is currently required from: Angel Pons, Peter Marheine.
Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69064 )
Change subject: flashrom_tester: Change string types to path types where appropriate
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/69064/comment/865ac338_a68bb7f3
PS1, Line 7: String
`str` not `String`, a `String` is a heap allocated "string" while a `str` is a stack allocated "stri […]
good point, i changed to 'string' as the rust book does
https://review.coreboot.org/c/flashrom/+/69064/comment/3d96ac1a_92c2219a
PS1, Line 9: String
s/String/Stack allocated str's with life-time 'a'/
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/69064
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I69531bec5436a60430eae975eeab02c8835962bf
Gerrit-Change-Number: 69064
Gerrit-PatchSet: 2
Gerrit-Owner: Evan Benn
evanbenn@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Tue, 01 Nov 2022 02:06:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Gerrit-MessageType: comment