Attention is currently required from: Angel Pons, Peter Marheine.
View Change
2 comments:
Commit Message:
Patch Set #1, Line 7: String
`str` not `String`, a `String` is a heap allocated "string" while a `str` is a stack allocated "stri […]
good point, i changed to 'string' as the rust book does
Patch Set #1, Line 9: String
s/String/Stack allocated str's with life-time 'a'/
Done
To view, visit change 69064. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I69531bec5436a60430eae975eeab02c8835962bf
Gerrit-Change-Number: 69064
Gerrit-PatchSet: 2
Gerrit-Owner: Evan Benn <evanbenn@google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Peter Marheine <pmarheine@chromium.org>
Gerrit-Comment-Date: Tue, 01 Nov 2022 02:06:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-MessageType: comment