Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk, Sergii Dmytruk.
Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69847 )
Change subject: writeprotect: Add function to get register values and WP bit masks ......................................................................
Patch Set 8:
(3 comments)
This change is ready for review.
Commit Message:
https://review.coreboot.org/c/flashrom/+/69847/comment/9b51163e_7656cb26 PS5, Line 7: writeprotect: Add function to get register values and WP bit masks
Is this to allow updating WP registers via some non-standard method? Would be nice to have outline […]
It will allow us to more thoroughly qualify flash chips once flashrom_tester is able to query the register values during testing. I've uploaded a WIP commit to add a libflashrom interface as well in CB:73053.
File tests/chip_wp.c:
https://review.coreboot.org/c/flashrom/+/69847/comment/4e669625_91f5162f PS5, Line 363: strdup(
you do not need a heap allocation, just a `const char *`
Done
https://review.coreboot.org/c/flashrom/+/69847/comment/1020316e_60eb7497 PS5, Line 396: free(param_dup);
drop
Done