Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk, Sergii Dmytruk.

View Change

3 comments:

• Commit Message:

  • Patch Set #5, Line 7: writeprotect: Add function to get register values and WP bit masks

    Is this to allow updating WP registers via some non-standard method? Would be nice to have outline […]

    It will allow us to more thoroughly qualify flash chips once flashrom_tester is able to query the register values during testing. I've uploaded a WIP commit to add a libflashrom interface as well in CB:73053.

• File tests/chip_wp.c:

  • Patch Set #5, Line 363: strdup(

    you do not need a heap allocation, just a `const char *`

    Done

  • Patch Set #5, Line 396: free(param_dup);

    drop

    Done

To view, visit change 69847. To unsubscribe, or for help writing mail filters, visit settings.