Attention is currently required from: Anastasia Klimchuk, Sergii Dmytruk.
Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74930 )
Change subject: flashrom: Use WP-based unlocking on opaque masters ......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/74930/comment/a611c1ea_3eac0aa9 PS2, Line 9: detectes
nit: `detects`
Done
File tests/chip.c:
https://review.coreboot.org/c/flashrom/+/74930/comment/a9ecb171_f936e942 PS2, Line 78: static int unlock_chip(struct flashctx *flash)
Why was this stuff dropped?
This test was failing because it expected the chip unlock function to be called, but flashrom now uses the dummy WP to unlock the chip instead.
After removing the parts of the test that checked for unlock calls, there was no reason to keep the injector around.
Also it is less important to test that unlock is called now that WP unlocking is the default supported path.