Attention is currently required from: Anastasia Klimchuk, Sergii Dmytruk.

View Change

2 comments:

• Commit Message:

  • Patch Set #2, Line 9: detectes

    nit: `detects`

    Done

• File tests/chip.c:

  • Patch Set #2, Line 78: static int unlock_chip(struct flashctx *flash)

    Why was this stuff dropped?

    This test was failing because it expected the chip unlock function to be called, but flashrom now uses the dummy WP to unlock the chip instead.

    After removing the parts of the test that checked for unlock calls, there was no reason to keep the injector around.

    Also it is less important to test that unlock is called now that WP unlocking is the default supported path.

To view, visit change 74930. To unsubscribe, or for help writing mail filters, visit settings.