Attention is currently required from: Thomas Heijligen.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72656 )
Change subject: meson: use cfg_data for to evaluate cflags ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/72656/comment/da765064_703cab26 PS1, Line 7: use cfg_data for to evaluate cflags there is a bit more going on here like the version switching from the meson project to something decent so maybe just elaborate a bit.
File meson.build:
https://review.coreboot.org/c/flashrom/+/72656/comment/b9b6137e_269b66bc PS1, Line 481: : config.set('CONFIG_DEFAULT_PROGRAMMER_NAME', get_option('default_programmer_name') != '' ? '&programmer_' + get_option('default_programmer_name') : 'NULL') not sure I like the embedded ternary operator use in this case, could it be assigned to a intermediate for clarity? But whatever, it isn't a big deal.