Attention is currently required from: Thomas Heijligen.

View Change

2 comments:

• Commit Message:

  • Patch Set #1, Line 7: use cfg_data for to evaluate cflags

    there is a bit more going on here like the version switching from the meson project to something decent so maybe just elaborate a bit.

• File meson.build:

  • Patch Set #1, Line 481:

    
    config.set('CONFIG_DEFAULT_PROGRAMMER_NAME', get_option('default_programmer_name') != '' ? '&programmer_' + get_option('default_programmer_name') : 'NULL')
    

    not sure I like the embedded ternary operator use in this case, could it be assigned to a intermediate for clarity? But whatever, it isn't a big deal.

To view, visit change 72656. To unsubscribe, or for help writing mail filters, visit settings.