[flashrom-gerrit] Change in flashrom[master]: ichspi.c: Implement ich_hwseq_get_flash_id()

[Sam McNally (Code Review)]

Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48133 )

Change subject: ichspi.c: Implement ich_hwseq_get_flash_id()
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/flashrom/+/48133/1/ichspi.c 
File ichspi.c:

https://review.coreboot.org/c/flashrom/+/48133/1/ichspi.c@1393 
PS1, Line 1393: 		flash->chip->feature_bits = entry->feature_bits;
> Well it's the other way around right, 4BA is currently broken and this just surfaces the underlying  […]

Without this CL flashrom remains ignorant of 4ba support and with ich_hwseq reading from a 32MB chip works (assuming the map_flash() error is ignored). With this CL it fails or crashes (again with the map_flash() error ignored).