View Change
1 comment:
File ichspi.c:
Patch Set #1, Line 1393: flash->chip->feature_bits = entry->feature_bits;
Well it's the other way around right, 4BA is currently broken and this just surfaces the underlying […]
Without this CL flashrom remains ignorant of 4ba support and with ich_hwseq reading from a 32MB chip works (assuming the map_flash() error is ignored). With this CL it fails or crashes (again with the map_flash() error ignored).
To view, visit change 48133. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Icdf684e21b19ee87b797092f3cf0353e1184291f
Gerrit-Change-Number: 48133
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Sam McNally <sammc@google.com>
Gerrit-Reviewer: Stefan Reinauer <reinauer@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Mon, 30 Nov 2020 08:17:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sam McNally <sammc@google.com>
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-MessageType: comment