[flashrom-gerrit] Change in flashrom[master]: ft2232_spi.c: Pack WREN and op in one ftdi_write_data() call

[Simon Buhrow (Code Review)]

Simon Buhrow has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40477 )

Change subject: ft2232_spi.c: Pack WREN and op in one ftdi_write_data() call
......................................................................

Patch Set 16:

(2 comments)

Sounds good. I hope you get time soon :-)

https://review.coreboot.org/c/flashrom/+/40477/14/ft2232_spi.c 
File ft2232_spi.c:

https://review.coreboot.org/c/flashrom/+/40477/14/ft2232_spi.c@480 
PS14, Line 480: /*
              : 		* 280 bytes =
              : 		*   + 9 B (CMD)
              : 		*   + 1 B (WREN)
              : 		*   + 9 B (CMD)
              : 		*   + 1 B (op)          \
              : 		*   + 4 B (addr)        | = writecnt
              : 		*   + 256 B (page data) /
              : 		*
              : 		* With op: PageProgram or Erase; CMD: FTDI-Chip commands
              : 		*/
> nit: I'd place this before the assignment to `bufsize`. […]

Done

https://review.coreboot.org/c/flashrom/+/40477/14/ft2232_spi.c@555 
PS14, Line 555: /* Return to get second op (Program or Erase) without
              : 		 * resetting buf nor i*/
> Comment style should be: […]

Done