Sounds good. I hope you get time soon :-)
View Change
2 comments:
File ft2232_spi.c:
Patch Set #14, Line 480:
/*
* 280 bytes =
* + 9 B (CMD)
* + 1 B (WREN)
* + 9 B (CMD)
* + 1 B (op) \
* + 4 B (addr) | = writecnt
* + 256 B (page data) /
*
* With op: PageProgram or Erase; CMD: FTDI-Chip commands
*/
nit: I'd place this before the assignment to `bufsize`. […]
Done
Patch Set #14, Line 555:
/* Return to get second op (Program or Erase) without
* resetting buf nor i*/
Comment style should be: […]
Done
To view, visit change 40477. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie4a07499ec5ef0af23818593f45dc427285a9e8a
Gerrit-Change-Number: 40477
Gerrit-PatchSet: 16
Gerrit-Owner: Simon Buhrow
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Patrick Georgi <pgeorgi@google.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Thu, 24 Sep 2020 11:53:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment