Attention is currently required from: Simon Buhrow, Aarya.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/65844 )
Change subject: flashrom.c:Add a function to get list of sectors that need erasing ......................................................................
Patch Set 73: Code-Review+2
(6 comments)
File erasure_layout.c:
https://review.coreboot.org/c/flashrom/+/65844/comment/10acfaa5_736a3d05 PS73, Line 127: void * `void *` in type system speak is mostly like putting on a blind-fold and jumping between a large canyon hoping you will arrive on the other side safely.
These contents buffers are byte array's on the heap, use the correct type of `uint8_t`.
https://review.coreboot.org/c/flashrom/+/65844/comment/4eda0de4_5f8081d4 PS73, Line 127: region_start `rstart` and Doxygen.
https://review.coreboot.org/c/flashrom/+/65844/comment/460a9985_2047f4bf PS73, Line 127: region_end `rend` and Doxygen.
https://review.coreboot.org/c/flashrom/+/65844/comment/6412aab7_4c1e4220 PS73, Line 127: struct flashctx *flashctx, by convention, keep the `flashctx` as the first argument to the function, it helps keep the code-base more consistent for one reason of a few.
like wrap the function definition.
https://review.coreboot.org/c/flashrom/+/65844/comment/65363ac0_60541c38 PS73, Line 127: function_index `findex` and in the Doxygen comment you can say "function index".
https://review.coreboot.org/c/flashrom/+/65844/comment/81e7ac06_e23e463a PS73, Line 130: function_index == 0 `!foo` is canonical for the 0 or NULL case.