3 Apr
2022
3 Apr
'22
9:47 p.m.
Attention is currently required from: Subrata Banik, Nico Huber, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62891 )
Change subject: ichspi: Introduce FCYCLE_MASK(n) macro ......................................................................
Patch Set 6:
(2 comments)
Patchset:
PS6: What's the benefit of these changes? To me, the `FCYCLE_MASK` macro makes things more noisy. Also, note that the definitions are organized so that PCH100 differences appear first.
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/62891/comment/ed7a7ecf_b98d8a2d PS6, Line 162: n Please add parentheses around macro parameters
--
To view, visit https://review.coreboot.org/c/flashrom/+/62891
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id222304165610c7ae48e365d72ec8fdeea51c51d
Gerrit-Change-Number: 62891
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Subrata Banik subi.banik@gmail.com
Gerrit-Attention: Subrata Banik subi.banik@gmail.com
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Sun, 03 Apr 2022 21:47:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment