Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Sergii Dmytruk.
Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58481 )
Change subject: libflashrom,writeprotect: add flashrom_wp_get_available_ranges()
......................................................................
Patch Set 11:
(3 comments)
File writeprotect.c:
https://review.coreboot.org/c/flashrom/+/58481/comment/dee3641b_00feabce
PS10, Line 271: ranges[++last] = ranges[i];
Thank you! […]
Done
https://review.coreboot.org/c/flashrom/+/58481/comment/fec2ffd6_8b09854f
PS10, Line 271: ranges[++last] = ranges[i];
Thank you! […]
I've rewritten the loop to avoid edge cases and be easier to read.
Probably out of scope for now, but maybe should we have a separate file for collecting common algorithms like this (sort, binary search, deduplicate, etc) instead of repeating them in various places?
https://review.coreboot.org/c/flashrom/+/58481/comment/8721f486_2d9a7be3
PS10, Line 274: *count = last + 1;
If `*count` was 0 initially, i.e. an empty list, this would set it to `1`.
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/58481
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id51f038f03305c8536d80313e52f77d27835f34d
Gerrit-Change-Number: 58481
Gerrit-PatchSet: 11
Gerrit-Owner: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Fri, 19 Nov 2021 10:20:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment