Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Sergii Dmytruk.

View Change

3 comments:

• File writeprotect.c:

  • Patch Set #10, Line 271: ranges[++last] = ranges[i];

    Thank you! […]

    Done

  • Patch Set #10, Line 271: ranges[++last] = ranges[i];

    Thank you! […]

    I've rewritten the loop to avoid edge cases and be easier to read.

    Probably out of scope for now, but maybe should we have a separate file for collecting common algorithms like this (sort, binary search, deduplicate, etc) instead of repeating them in various places?

  • Patch Set #10, Line 274: *count = last + 1;

    If `*count` was 0 initially, i.e. an empty list, this would set it to `1`.

    Done

To view, visit change 58481. To unsubscribe, or for help writing mail filters, visit settings.