Attention is currently required from: Peter Marheine.
Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71973 )
Change subject: flashrom_tester: Rewrite IOOpts to support more operations ......................................................................
Patch Set 6:
(1 comment)
File util/flashrom_tester/flashrom/src/cmd.rs:
https://review.coreboot.org/c/flashrom/+/71973/comment/089374d1_9ff97315 PS4, Line 82: // an operation must provide a file or a region.file or both.
If each operation can take both a region and file path (or more generally, if every operation can ta […]
I think you are saying some things I get and some that I dont, I have had another attempt PTAL.
An operation takes either - a file and an array of regions with optional files - a region with a file, and an array of regions with optional files
and orthogonally, a layout.
and the erase operation doesnt take args, because i dont need it to.
I have not tried to represent this all in the type system, because I dont need all the variations, but I do need some of them, which is what I have implemented.