Attention is currently required from: Peter Marheine.

View Change

1 comment:

• File util/flashrom_tester/flashrom/src/cmd.rs:

  • Patch Set #4, Line 82: // an operation must provide a file or a region.file or both.

    If each operation can take both a region and file path (or more generally, if every operation can ta […]

    I think you are saying some things I get and some that I dont, I have had another attempt PTAL.

    An operation takes either

    • a file and an array of regions with optional files
    • a region with a file, and an array of regions with optional files

    and orthogonally, a layout.

    and the erase operation doesnt take args, because i dont need it to.

    I have not tried to represent this all in the type system, because I dont need all the variations, but I do need some of them, which is what I have implemented.

To view, visit change 71973. To unsubscribe, or for help writing mail filters, visit settings.