[flashrom-gerrit] [M] Change in flashrom[main]: libflashrom: Add API for capabilitible chips

[Anastasia Klimchuk (Code Review)]

Attention is currently required from: Dmitry Zhadinets, Peter Marheine.

Anastasia Klimchuk has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/87251?usp=email )

Change subject: libflashrom: Add API for capabilitible chips
......................................................................

Patch Set 4:

(1 comment)

File tests/tests.c:

https://review.coreboot.org/c/flashrom/+/87251/comment/588af163_e5e4dbcd?usp... :
PS4, Line 496: 	const struct CMUnitTest libflashrom_tests[] = {
             : 		cmocka_unit_test(flashrom_set_log_callback_test_success),
             : 		cmocka_unit_test(flashrom_set_log_callback_v2_test_success),
             : 		cmocka_unit_test(flashrom_set_log_level_test_success),
             : 		cmocka_unit_test(flashrom_supported_programmers_test_success),
             : 		cmocka_unit_test(flashrom_programmer_capabilities_test_success),
             : 	};
             : 	ret |= cmocka_run_group_tests_name("libflashrom.c tests", libflashrom_tests, NULL, NULL);
             : 
I could repro the failing test/spi25.c when I downloaded the patch and reverted the diffs in tests/tests.c (moved the lines back).

4 errors, they look similar like this:

```
[  ERROR   ] --- %s() has remaining non-returned values.
: __wrap_spi_send_command../tests/spi25.c:167: note: remaining item was declared here
../tests/spi25.c:168: note: remaining item was declared here
../tests/spi25.c:169: note: remaining item was declared here
__wrap_spi_send_command: '%s' parameter still has values that haven't been checked.
: flash../tests/spi25.c:164: note: remaining item was declared here
```

I am not sure which test has a bug, need to have a look. The failing sequence has libflashrom_tests first and spi25_tests after that.