Attention is currently required from: Dmitry Zhadinets, Peter Marheine.

View Change

1 comment:

• File tests/tests.c:

  • Patch Set #4, Line 496:

    	const struct CMUnitTest libflashrom_tests[] = {
    		cmocka_unit_test(flashrom_set_log_callback_test_success),
    		cmocka_unit_test(flashrom_set_log_callback_v2_test_success),
    		cmocka_unit_test(flashrom_set_log_level_test_success),
    		cmocka_unit_test(flashrom_supported_programmers_test_success),
    		cmocka_unit_test(flashrom_programmer_capabilities_test_success),
    	};
    	ret |= cmocka_run_group_tests_name("libflashrom.c tests", libflashrom_tests, NULL, NULL);
    
    

    I could repro the failing test/spi25.c when I downloaded the patch and reverted the diffs in tests/tests.c (moved the lines back).

    4 errors, they look similar like this:

    ```
    [ ERROR ] --- %s() has remaining non-returned values.
    : __wrap_spi_send_command../tests/spi25.c:167: note: remaining item was declared here
    ../tests/spi25.c:168: note: remaining item was declared here
    ../tests/spi25.c:169: note: remaining item was declared here
    __wrap_spi_send_command: '%s' parameter still has values that haven't been checked.
    : flash../tests/spi25.c:164: note: remaining item was declared here
    ```

    I am not sure which test has a bug, need to have a look. The failing sequence has libflashrom_tests first and spi25_tests after that.

To view, visit change 87251. To unsubscribe, or for help writing mail filters, visit settings.