Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48662 ) Change subject: realtek_mst_i2c_spi.c: Add ISP mode check ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/c/flashrom/+/48662/1/realtek_mst_i2c_spi.c File realtek_mst_i2c_spi.c: https://review.coreboot.org/c/flashrom/+/48662/1/realtek_mst_i2c_spi.c@133 PS1, Line 133: /* wait for isp enter */ : int retry = 10; : while (retry-- > 0) { : if (realtek_mst_i2c_spi_in_isp_mode(fd) == 1) : break; : struct timespec wait_200ms = { 0, (unsigned)2e8 }; : nanosleep(&wait_200ms, NULL); : } : : if (retry < 0) : return SPI_GENERIC_ERROR; I think this is re-implementing, `realtek_mst_i2c_spi_wait_command_done(fd, MCU_MODE, MCU_ISP_MODE_MASK, 0, 1);` -- To view, visit https://review.coreboot.org/c/flashrom/+/48662 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib1ab8370eb6335a77bb293fc98a8ab7be465db4f Gerrit-Change-Number: 48662 Gerrit-PatchSet: 1 Gerrit-Owner: Shiyu Sun <sshiyu@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Comment-Date: Thu, 17 Dec 2020 02:58:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment