Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48662 )
Change subject: realtek_mst_i2c_spi.c: Add ISP mode check ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/flashrom/+/48662/1/realtek_mst_i2c_spi.c File realtek_mst_i2c_spi.c:
https://review.coreboot.org/c/flashrom/+/48662/1/realtek_mst_i2c_spi.c@133 PS1, Line 133: /* wait for isp enter */ : int retry = 10; : while (retry-- > 0) { : if (realtek_mst_i2c_spi_in_isp_mode(fd) == 1) : break; : struct timespec wait_200ms = { 0, (unsigned)2e8 }; : nanosleep(&wait_200ms, NULL); : } : : if (retry < 0) : return SPI_GENERIC_ERROR; I think this is re-implementing, `realtek_mst_i2c_spi_wait_command_done(fd, MCU_MODE, MCU_ISP_MODE_MASK, 0, 1);`