Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44621 )
Change subject: allow 0x34 as ICCRIBA for CHIPSET_C620_SERIES_LEWISBURG ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/flashrom/+/44621/1/ich_descriptors.c File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/44621/1/ich_descriptors.c@1248 PS1, Line 1248: msg_cerr
msg_perr
Done
https://review.coreboot.org/c/flashrom/+/44621/1/ich_descriptors.c@1248 PS1, Line 1248: "__FUNC__, __LINE__ Failed with value %d.\n", ret
I don't think we're supposed to print anything in here, but let the callers handle errors instead. […]
The problem is that when read_ich_descriptors_from_dump() returns non-successful status, layout_from_ich_descriptors() just return 1.
In a failure scenario, what the user gets: Reading ich descriptor... done. Couldn't parse the descriptor!
With adding of this print, the user gets: Reading ich descriptor... done. layout_from_ich_descriptors():1249, returned with value -4. Couldn't parse the descriptor!