View Change

2 comments:

• File ich_descriptors.c:

  • Patch Set #1, Line 1248: msg_cerr

    msg_perr

    Done

  • Patch Set #1, Line 1248: "__FUNC__, __LINE__ Failed with value %d.\n", ret

    I don't think we're supposed to print anything in here, but let the callers handle errors instead. […]

    The problem is that when read_ich_descriptors_from_dump() returns non-successful status, layout_from_ich_descriptors() just return 1.

    In a failure scenario, what the user gets:
    Reading ich descriptor... done.
    Couldn't parse the descriptor!

    With adding of this print, the user gets:
    Reading ich descriptor... done.
    layout_from_ich_descriptors():1249, returned with value -4.
    Couldn't parse the descriptor!

To view, visit change 44621. To unsubscribe, or for help writing mail filters, visit settings.