David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35592 )
Change subject: cli_classic: Add convenient '--{flash,get}-size' cli opt
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
For upstream, you should probably also update cli_classic_usage() and the man page. For this patch I think adding --flash-size should be sufficient, but let's see what others have to say about this approach.
https://review.coreboot.org/c/flashrom/+/35592/5/cli_classic.c
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/35592/5/cli_classic.c@137
PS5, Line 137: {"get-size", 0, NULL, OPTION_GET_SIZE},
This would create a lot of frustration dealing with retooling chromiumos to handle two flashroms wit […]
Does --help show the option? I don't see any changes to cli_classic_usage() in this patch (or the previous one).
--
To view, visit
https://review.coreboot.org/c/flashrom/+/35592
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8f002f3b2012aec4d26b0e81456697b9a5de28d6
Gerrit-Change-Number: 35592
Gerrit-PatchSet: 6
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Alan Green
avg@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 04 Oct 2019 04:11:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: David Hendricks
david.hendricks@gmail.com
Gerrit-MessageType: comment