For upstream, you should probably also update cli_classic_usage() and the man page. For this patch I think adding --flash-size should be sufficient, but let's see what others have to say about this approach.

Patch set 6:Code-Review +1

View Change

1 comment:

• File cli_classic.c:

  • Patch Set #5, Line 137: {"get-size", 0, NULL, OPTION_GET_SIZE},

    This would create a lot of frustration dealing with retooling chromiumos to handle two flashroms wit […]

    Does --help show the option? I don't see any changes to cli_classic_usage() in this patch (or the previous one).

To view, visit change 35592. To unsubscribe, or for help writing mail filters, visit settings.